Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcc@13 13.3.0 #171932

Merged
merged 2 commits into from
May 22, 2024
Merged

gcc@13 13.3.0 #171932

merged 2 commits into from
May 22, 2024

Conversation

fxcoudert
Copy link
Member

Testing of the 13.3.0 release candidate

@fxcoudert fxcoudert added the prerelease-testing Pull request from upstream, testing a pre-release with homebrew dependencies label May 16, 2024
@github-actions github-actions bot added legacy Relates to a versioned @ formula long build Needs CI-long-timeout labels May 16, 2024
@fxcoudert fxcoudert added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label May 17, 2024
@fxcoudert fxcoudert removed the prerelease-testing Pull request from upstream, testing a pre-release with homebrew dependencies label May 21, 2024
@fxcoudert fxcoudert marked this pull request as ready for review May 21, 2024 09:51
@fxcoudert
Copy link
Member Author

GCC 13.3 is released: https://gcc.gnu.org/pipermail/gcc/2024-May/243980.html

@fxcoudert
Copy link
Member Author

The release candidate (which was identical save one unrelated commit) built fine last week.

2024-05-21T10:13:37.6131904Z ../../gcc/lto-compress.cc:34:10: fatal error: zlib.h: No such file or directory
2024-05-21T10:13:37.6132010Z    34 | #include <zlib.h>
2024-05-21T10:13:37.6132093Z       |          ^~~~~~~~
2024-05-21T10:13:37.6132256Z compilation terminated.

Did something change on our Linux CI machines?

@p-linnane
Copy link
Member

p-linnane commented May 21, 2024

Did something change on our Linux CI machines?

We dropped libz: Homebrew/brew#16702

@fxcoudert
Copy link
Member Author

  Error: Failed changing install name in /usr/local/Cellar/gcc@13/13.3.0/libexec/gcc/x86_64-apple-darwin21/13/cc1
    from /usr/local/opt/zstd/lib/libzstd.1.dylib
      to @@HOMEBREW_PREFIX@@/opt/zstd/lib/libzstd.1.dylib
  Error: Updated load commands do not fit in the header of /usr/local/Cellar/gcc@13/13.3.0/libexec/gcc/x86_64-apple-darwin21/13/cc1. /usr/local/Cellar/gcc@13/13.3.0/libexec/gcc/x86_64-apple-darwin21/13/cc1 needs to be relinked, possibly with -headerpad or -headerpad_max_install_names

# Avoid this semi-random failure:
# "Error: Failed changing install name"
# "Updated load commands do not fit in the header"
make_args = %w[BOOT_LDFLAGS=-Wl,-headerpad_max_install_names]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this preferable to the --with-boot-ldflags argument of configure?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We used the make variable before, I think because otherwise the default value of --with-boot-ldflags is overwritten. I'm just choosing the same as other existing gcc versioned formulas, for consistency.

Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label May 22, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue May 22, 2024
Merged via the queue into Homebrew:master with commit 5ea5b98 May 22, 2024
14 checks passed
@fxcoudert fxcoudert deleted the gcc13 branch May 22, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. legacy Relates to a versioned @ formula long build Needs CI-long-timeout
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants