Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #43

Merged
merged 1 commit into from
May 19, 2024
Merged

Fix CI #43

merged 1 commit into from
May 19, 2024

Conversation

SMillerDev
Copy link
Member

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • brew cask install {{cask_file}} worked successfully.
  • brew cask uninstall {{cask_file}} worked successfully.
  • Checked there are no open pull requests for the same cask.
  • Checked the cask was not already refused in closed issues.
  • Checked the cask is submitted to the correct repo.

@SMillerDev SMillerDev force-pushed the patch-1 branch 2 times, most recently from 792b309 to 3fe136f Compare May 17, 2024 10:59
@tani
Copy link
Member

tani commented May 19, 2024

Thank you so much!

@tani tani marked this pull request as ready for review May 19, 2024 03:52
@tani tani merged commit d6c9744 into Homebrew:master May 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants